-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to zarr 3 and main kerchunk #406
base: main
Are you sure you want to change the base?
Conversation
I don't know that this PR can be disentangled from the changes we need to get icechunk working with zarr v3... |
I can take the new in-memory icechunk stuff and leave the place where it could slot in. Or this can just be used as a reference point. I'm not attached 😄 |
So IIUC we can either:
|
I'd slightly prefer if we merged this now because it seems to me like this PR really breaks the stalemate that we were in and would unblock other work. specifically for my work, I'd love to merge it into #407 to get the updates already implemented |
@@ -39,7 +39,7 @@ hdf_reader = [ | |||
"numcodecs" | |||
] | |||
icechunk = [ | |||
"icechunk==0.1.0a8", | |||
"icechunk>=0.1.0a12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsignell what's the motivation for using a12 rather than a15?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this comment: #378 (comment) and so I thought a12 would be ok. And I looked at the codebase for the latest tagged version of icechunk and I saw this line which made me nervous about using newer than a12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks for sharing!
I'm happy to merge this now if @jsignell is. We want to block everyone else as little as possible. |
Pulls commits from #378, #405 and #393
UPDATE: Ideas for #376 removed in 42414f0
docs/releases.rst
api.rst
The remaining failures on upstream can be broken into: