Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize is_total_slice for chunksize == 1 #2782

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Optimize is_total_slice for chunksize == 1 #2782

merged 1 commit into from
Jan 30, 2025
+23 −4

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jan 30, 2025 •
edited
Loading

Avoid an unnecessary get when overwriting a whole chunk using "orthogonal selection"

TODO:

  • Add unit tests and/or doctests in docstrings
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dcherian dcherian requested a review from d-v-b January 30, 2025 19:46
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jan 30, 2025
@dcherian dcherian force-pushed the opt-is-total-slice-chunk-size-1 branch from 037ac4e to a3f7d67 Compare January 30, 2025 19:47
@dcherian
Copy link
Contributor Author

WTH I've been here before! https://github.com/zarr-developers/zarr-python/pull/1800/files

@paraseba
Copy link
Contributor

👍 great catch @dcherian

@d-v-b
Copy link
Contributor

d-v-b commented Jan 30, 2025

WTH I've been here before! https://github.com/zarr-developers/zarr-python/pull/1800/files

what happened to that PR? did it get nullified by a merge conflict or something?

@d-v-b
Copy link
Contributor

d-v-b commented Jan 30, 2025

ah, those changes were made before 3.0 dropped

@dcherian dcherian merged commit 15d9260 into zarr-developers:main Jan 30, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcherian @paraseba @d-v-b @jhamman