Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to use os.walk to speedup reading from Directory Store #563

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented May 9, 2020

usage of os.walk for tree (os.scandir for folders) is faster than
listdir as it avoids many stats call.

This Should make the DirectoryStore faster.

See #562

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

@pep8speaks
Copy link

pep8speaks commented May 9, 2020

Hello @Carreau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-14 16:16:45 UTC

@Carreau Carreau marked this pull request as ready for review May 11, 2020 21:51
usage of os.walk for tree (os.scandir for folders) is faster than
listdir as it avoids many stats call.

This Should make the DirectoryStore faster.
@Carreau Carreau added this to the v2.5 milestone Sep 14, 2020
@Carreau Carreau merged commit 13966ba into zarr-developers:master Sep 14, 2020
@Carreau Carreau deleted the os-wlk branch September 14, 2020 18:07
@joshmoore
Copy link
Member

joshmoore commented Sep 14, 2020

Hi @Carreau. Did you mean for this to be proactively merged? I may be missing something but based on https://github.com/zarr-developers/governance/blob/master/GOVERNANCE.md#decision-making-process I'd think this needed a ":thumbsup:" perhaps especially after a force-pushed. Sorry if I'm missing something. After putting the governance doc in place, there likely should have been a discussion about GitHub settings. I'll kick that off separately.

Edit: see zarr-developers/governance#12

@Carreau
Copy link
Contributor Author

Carreau commented Sep 14, 2020

Sorry for the discussion on Friday I thought that it was or to try to move some of these small changes.

The force push was a rebase to make sure this was tested on a more recent version of the repo. I'm happy to get that reverted.

@joshmoore
Copy link
Member

joshmoore commented Sep 14, 2020

You can have a post-hoc zombie 👍 (necro-review?) from me. More a question of the process moving forward. Don't hesitate to ping and holler on a PR if you need motion.

@jakirkham jakirkham mentioned this pull request Dec 1, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants