Added NPE on null status in setTestCaseStatus

zebrunner · Feb 25, 2025 · 9ee9324 · 9ee9324
1 parent b1b4214
commit 9ee9324
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 1 deletion.
diff --git a/src/main/java/com/zebrunner/agent/core/registrar/TestCase.java b/src/main/java/com/zebrunner/agent/core/registrar/TestCase.java
@@ -54,7 +54,7 @@ public static void setTestCaseKey(String testCaseKey) {
      *
      * @param testCaseKey  key of the test case
      * @param resultStatus name of the status to be set for the test case
-     * @see SystemTestCaseStatus
+     * @throws NullPointerException if {@code resultStatus} is null
      * @see SystemTestCaseStatus
      */
     public static void setTestCaseStatus(String testCaseKey, String resultStatus) {

diff --git a/src/main/java/com/zebrunner/agent/core/registrar/TestCasesRegistry.java b/src/main/java/com/zebrunner/agent/core/registrar/TestCasesRegistry.java
@@ -9,6 +9,7 @@
 import java.util.EnumMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
@@ -67,6 +68,8 @@ void addTestCasesToCurrentTest(TcmType tcmType, Collection<String> testCaseIds)
     }
 
     void setCurrentTestTestCaseStatus(TcmType tcmType, String testCaseId, String status) {
+        Objects.requireNonNull(status, "Status cannot be null.");
+
         RunContext.getCurrentTest()
                   .map(TestDescriptor::getZebrunnerId)
                   .ifPresent(testId -> {

diff --git a/src/main/java/com/zebrunner/agent/core/registrar/TestRail.java b/src/main/java/com/zebrunner/agent/core/registrar/TestRail.java
@@ -95,6 +95,7 @@ public static void setTestCaseId(String testCaseId) {
      *
      * @param testCaseId   TestRail id of the test case. Can be either a regular number or a number with the letter 'C' at the begging.
      * @param resultStatus system name (not labels!) of the status to be set for the test case
+     * @throws NullPointerException if {@code resultStatus} is null
      * @see SystemTestCaseStatus
      */
     public static void setTestCaseStatus(String testCaseId, String resultStatus) {

diff --git a/src/main/java/com/zebrunner/agent/core/registrar/Xray.java b/src/main/java/com/zebrunner/agent/core/registrar/Xray.java
@@ -54,6 +54,7 @@ public static void setTestKey(String testKey) {
      *
      * @param testKey      key of the Xray test
      * @param resultStatus name of the status to be set for the test
+     * @throws NullPointerException if {@code resultStatus} is null
      * @see SystemTestStatus.Cloud
      * @see SystemTestStatus.Server
      */

diff --git a/src/main/java/com/zebrunner/agent/core/registrar/Zephyr.java b/src/main/java/com/zebrunner/agent/core/registrar/Zephyr.java
@@ -59,6 +59,7 @@ public static void setTestCaseKey(String testCaseKey) {
      *
      * @param testCaseKey  key of the Zephyr test case
      * @param resultStatus name of the status to be set for the test case
+     * @throws NullPointerException if {@code resultStatus} is null
      * @see Scale.SystemTestCaseStatus.Cloud
      * @see Squad.SystemTestCaseStatus.Cloud
      */