Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the rest of mcardGCN.c #179

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Match the rest of mcardGCN.c #179

merged 7 commits into from
Sep 19, 2024

Conversation

cadmic
Copy link
Collaborator

@cadmic cadmic commented Sep 18, 2024

Sorry for the large PR, a lot of the code seems pretty repetitive. I'll try to do cleanups in a follow-up PR, namely:

  • give names for constants
  • use true/false consistently for boolean variables (like saveToggle)
  • make a macro for (u32)(x + 8187) / 8188

Copy link
Collaborator

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of those values are probably macros from the SDK
otherwise I think what I commented here are things that are planned for cleanup, nice work!

@cadmic cadmic merged commit a095e73 into zeldaret:main Sep 19, 2024
2 checks passed
@cadmic cadmic deleted the mcard2 branch September 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants