gen_mmu_x86.py fixes #4707
Merged
gen_mmu_x86.py fixes #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set XD at page directory level - some leaf PTE may have it cleared. Fixes: d170369 ("x86: MMU: Generation of PAE tables") Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Jan Kiszka <[email protected]>
It's x86-only. Signed-off-by: Jan Kiszka <[email protected]>
andrewboie
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the page fault due to spurious XD settings in PAE page directory tables as seen in PR #4170 and also performs two small cleanups on the script.
The XD issue may have remained unnoticed to far if all testes boards had memory layouts that had not mixtures of XD and non-XD in the same 2M region.