Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/fatfst: Add support for default ffconf.h FF_VOLUME_STRS override #57183

Closed

Conversation

tbursztyka
Copy link
Collaborator

@tbursztyka tbursztyka commented Apr 24, 2023

FatFS is pretty unflexible when it comes to volume names where all are hardcoded and fixed.

So let's patch Zephyr to expose a Kconfig based volumes string which will be parsed by fatfs to fill up it's volumes list.

see fatfs's related PR zephyrproject-rtos/fatfs#17

FatFS is pretty unflexible when it comes to volume names where all are
hardcoded and fixey.

So let's patch Zephyr to expose a Kconfig based volumes string which
will be parsed by fatfs to fill up it's volumes list.

Signed-off-by: Tomasz Bursztyka <[email protected]>
@Laczen
Copy link
Collaborator

Laczen commented Apr 24, 2023

@tbursztyka, my knowledge on the fatfs system is to limited to evaluate if the proposal is the correct approach. Removing the review request.

@Laczen Laczen removed their request for review April 24, 2023 16:05
@de-nordic
Copy link
Collaborator

I am not in favour of extensive modifications to FAT FS code base, when they can be avoided.
I would rather have entire get_ldnumber function #ifdefed, which is two line modification and have it provided by module additions within Zephyr. This way we can even provide alternative path support where ':' is not required, which would make LittleFS and FAT FS use same path format and make it easier to switch between them.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jul 5, 2023
@github-actions github-actions bot closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: File System DNM This PR should not be merged (Do Not Merge) manifest-fatfs Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants