Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: add common configuration for CDC ACM UART #81308

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

boards: add common configuration for CDC ACM UART #81308

wants to merge 3 commits into from
+255 −770

Commits on Nov 15, 2024

  1. boards: add common configuration for CDC ACM UART 

    Many boards have similar code to configure the USB and CDC ACM UART that
they want to use as a logging or shell backend. Some of them have an
incorrect or incomplete configuration.

These boards do not have a built-in debug adapter, but a SoC with a USB
device controller and a bootloader with USB device support. Introduce
common CDC ACM UART configuration that these boards should use for
logging or shell backend to avoid duplicate or incorrect configuration.

Signed-off-by: Johann Fischer <[email protected]>
    @jfischer-no
    jfischer-no committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7aa9e3a View commit details
    Browse the repository at this point in the history

  2. boards: use board common CDC ACM UART configuration 

    Remove all USB and CDC ACM configuration in favor of common
configuraiton.

Do not adapt board-specific configurations such as unknown PID/VID or
string descriptors. There is no justification for using them on specific
boards, and we do not have formal approval to use them in the project
tree. Also, we need more uniform configuration, since the main reason
for enabling CDC ACM here is to allow users to run examples like
hello_world right out of the box. Of course, anyone is free to customize
these settings in their fork or downstream project.

Signed-off-by: Johann Fischer <[email protected]>
    @jfischer-no
    jfischer-no committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0fa745d View commit details
    Browse the repository at this point in the history

  3. boards: remove ECM/EEM from default configuration 

    The board hardware has no network interfaces, although the ECM/EEM class
implementation can provide Ethernet-like functionality and export it to
the host, this is no reason to default to a specific USB class
implementation.We do not make this kind of configuration for other
boards that have a USB device controller. Also, it may not be what a
user expects when using these boards with networking and a USB stack.

Signed-off-by: Johann Fischer <[email protected]>
    @jfischer-no
    jfischer-no committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b9a3072 View commit details
    Browse the repository at this point in the history