Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a chest_treasure to the game objects: map_start #149

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

HossamGouda
Copy link
Contributor

added new treasure object to the map_start
added treasure_chest.png asset image to the public/assets

Copy link

🙏 Thanks for your pull request @HossamGouda, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
149 35 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 27 76

Copy link

🙏 Thanks for your pull request @HossamGouda, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
149 35 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 27 76

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HossamGouda could you add a treasure sprite which also contains a treasure which is open?
Because then we can add a animation where the user can open it to receive a item.

- Implemented treasure chest game object
- Added sprites for closed and open states
- Included sound effect for chest opening
- Created interaction logic to open the chest and play sound
- Updated game objects index to include the treasure chest
Copy link

🙏 Thanks for your pull request @HossamGouda, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
149 74 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
5 27 78

Copy link

🙏 Thanks for your pull request @HossamGouda, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
149 74 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
5 27 78

Copy link

🙏 Thanks for your pull request @HossamGouda, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
149 52 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
5 27 78

Copy link

🙏 Thanks for your pull request @HossamGouda, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
149 52 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
5 27 78

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@r4pt0s r4pt0s merged commit 048d0c2 into zero-to-mastery:main Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants