This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Fix relative paths #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If baseurl with an existing path on App, don't overwrite it, just append to it.
Problem is that if baseurl is "https://hostname/acme/" the response to https://hostname/acme/order
would return an Order with in part:
```
"authorizations": [
"https://hostname/authz/:ID"
],
```
when it should be "https://hostname/acme/authz/..."
Signed-off-by: Nathaniel Clark <[email protected]>
utopiabound
force-pushed
the
relative-paths
branch
from
128d35d
to
c24bb67
Compare
Signed-off-by: Nathaniel Clark <[email protected]>
|
Sorry just got to looking at this. I would triple-check this runs against the test suite, as I strongly suspect one of these approaches is wrong. I would also double check this manually with certbot and "weird" situations by hand to ensure this is a longer-term change. Not saying you're wrong, but that this has potential to break the whole library, and that appropriate precautions are taken. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If baseurl with an existing path on App, don't overwrite it, just append to it.
Problem is that if baseurl is "https://hostname/acme/" the response to https://hostname/acme/order would return an Order with in part:
when it should be "https://hostname/acme/authz/..."