This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Allow Challenger::tick to take async callback.
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where we may want to do some async work in the `Challenger::tick` callback. Since `Challenger::tick` itself is async, it's trivial to make the callback async as well. This allows users to do non-blocking work inside the callback. Signed-off-by: Joe Grund <[email protected]>
|
Hi, any thoughts on this? |
|
Hey! Thanks for writing this up. There's not really anyone up to speed yet to review it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where we may want to do some async work in the
Challenger::tickcallback. SinceChallenger::tickitself is async, it's trivial to make the callback async as well.This allows users to do non-blocking work inside the callback.