Fail the app when binding to a port fails #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikh
reviewed
Mar 28, 2023
tests/service/mod.rs
Outdated
| let (tcp_socket, udp_socket) = match Server::bind(ip.ip()).await { | ||
| Ok(x) => x, | ||
| Err(_) => { | ||
| panic!("Could not bind port"); |
There was a problem hiding this comment.
might be better to change the sig of the return value to return Result<Vec<_>, anyhow::Error> so the original error doesn't get swallowed.
There was a problem hiding this comment.
Took a stab at that but then I'd have to change the signature Service::new and then of every test, so...
People running zeronsd tests can figure it out :)
There was a problem hiding this comment.
I'm not sure that's the best way, but I won't argue with you. :P
laduke
force-pushed
the
fail-when-cant-bind-port
branch
from
7c59e43
to
9a75376
Compare
|
Thanks. I couldn't get that to work for some reason and you motivated me to fix it. Now it makes errors that look like this: |
tokio is was eating the panics and continuing on with no socket listening on 53 making tokio crash would take a bunch of rewrite i think, so i moved the `bind` calls out to a different, non-async fn
laduke
force-pushed
the
fail-when-cant-bind-port
branch
from
9a75376
to
7a67efa
Compare
|
Glad to be of help! I hadn't used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokio is was eating the panics and continuing on
with no socket listening on 53
making tokio crash would take a bunch of rewrite,
i think, so i moved the
bindcalls out to a different fnThe error looks like this: