Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/beancount supported #142

Merged
merged 23 commits into from
May 9, 2023
Merged

Feature/beancount supported #142

merged 23 commits into from
May 9, 2023

Conversation

Kilerd
Copy link
Collaborator

@Kilerd Kilerd commented Apr 18, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #142 (db08e32) into main (3cbd668) will increase coverage by 3.14%.
The diff coverage is 40.77%.

❗ Current head db08e32 differs from pull request most recent head c8f8779. Consider uploading reports for the commit c8f8779 to get more accurate results

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   28.68%   31.83%   +3.14%     
==========================================
  Files          35       37       +2     
  Lines        2189     2639     +450     
==========================================
+ Hits          628      840     +212     
- Misses       1561     1799     +238     
Impacted Files Coverage Δ
cli/src/main.rs 0.00% <0.00%> (ø)
core/src/process.rs 20.25% <ø> (ø)
core/src/transform.rs 0.00% <0.00%> (ø)
core/src/utils/mod.rs 0.00% <0.00%> (ø)
server/src/lib.rs 0.00% <0.00%> (ø)
transformers/text/src/lib.rs 0.00% <0.00%> (ø)
transformers/beancount/src/parser.rs 29.43% <29.43%> (ø)
core/src/ledger.rs 43.61% <54.54%> (+2.70%) ⬆️
exporters/beancount/src/lib.rs 38.83% <58.62%> (+38.83%) ⬆️
exporters/text/src/lib.rs 83.61% <66.66%> (+0.75%) ⬆️
... and 3 more

... and 3 files with indirect coverage changes

@Kilerd
Copy link
Collaborator Author

Kilerd commented May 8, 2023

seems like nothing leave, zhang can parse and serve beancount's example data without any error.

@Kilerd
Copy link
Collaborator Author

Kilerd commented May 9, 2023

based on @Harry-Chen 's suggestions, we will seperate some tickets to enhance the exprience of usage of pushtag and poptag directives.

and this PR will only focus on the integration of beancount syntax. make sure zhang can work with beancount file without any changes.

@Kilerd Kilerd merged commit 3a2e36e into main May 9, 2023
@Kilerd Kilerd deleted the feature/beancount-supported branch May 9, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants