Unittests for meta- and resultnode #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasah
requested changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM.
I added a few comments. But the overall changes are very good.
A few general things:
- I think a few sporadic docstrings in the
conftest.pywould help the overall readability - I would also add return type hints for all fixtures, This will simplify the refactorings later on.
- Often there are more empty lines than needed. Can you check that there are no unnecessary empty lines? (two lines between classes and static functions, a single line between functions within classes.)
- Can you add a description to the MR
- Can you make a better commit message? (https://cbea.ms/git-commit/)
rayklauck
force-pushed
the
rayk/node_tests
branch
2 times, most recently
from
3477831 to
a469177
Compare
rayklauck
force-pushed
the
rayk/node_tests
branch
from
a469177 to
0329063
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
============================================
- Coverage 100.00% 85.44% -14.56%
============================================
Files 16 16
Lines 1292 1292
Branches 218 218
============================================
- Hits 1292 1104 -188
- Misses 0 179 +179
- Partials 0 9 +9
☔ View full report in Codecov by Sentry. |
use mocking and fixtures for cleaner unittests. Old tests are being replaced.
rayklauck
force-pushed
the
rayk/node_tests
branch
from
0329063 to
f2ad5b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unittests for MetaNode and ResultNode.