Allow passing a custom queue to the session subscribe #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasah
force-pushed
the
tobiasa/circular_queue
branch
from
b9073c0 to
b8d5054
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1511 1550 +39
Branches 248 262 +14
=========================================
+ Hits 1511 1550 +39 ☔ View full report in Codecov by Sentry. |
tobiasah
force-pushed
the
tobiasa/circular_queue
branch
from
b8d5054 to
d3b5c0b
Compare
This commit adds the option to add a custom queue class to the subscribe command on the session. This allows a more flexible usage of a subscription. As part of this change a new circular data queue is added which allows to have a a sort of ring buffer as a queue.
tobiasah
force-pushed
the
tobiasa/circular_queue
branch
from
d3b5c0b to
0dc8243
Compare
tobiasah
changed the title
markheik
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the option to add a custom queue class to the
subscribe command on the session. This allows a more flexible
usage of a subscription.
As part of this change a new circular data queue is added which
allows to have a a sort of ring buffer as a queue.