Unittesting Node and LeafNode #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rayklauck
commented
Nov 10, 2023
rayklauck
commented
- Writing verbose tests and bringing the coverage on these classes to 100%.
- Also extending previous tests to meet the coverage.
- Fixing details in nodetree implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 85.44% 88.54% +3.09%
==========================================
Files 16 16
Lines 1292 1292
Branches 218 218
==========================================
+ Hits 1104 1144 +40
+ Misses 179 143 -36
+ Partials 9 5 -4
☔ View full report in Codecov by Sentry. |
tobiasah
approved these changes
Nov 13, 2023
tests/nodetree/test_node_unit.py
Outdated
|
|
||
| def test_raw_tree(self): | ||
| with pytest.warns(DeprecationWarning): | ||
| MockMetaNode(()).raw_tree # noqa: B018 |
There was a problem hiding this comment.
issue: You should still test that the right value is returned
rayklauck
force-pushed
the
rayk/test_node2
branch
from
1e7ba5f to
1260d06
Compare
- Writing verbose tests and bringing the coverage on these classes to 100%. - Also extending previous tests to meet the coverage. - Fixing details in nodetree implementation.
rayklauck
force-pushed
the
rayk/test_node2
branch
from
1260d06 to
3621897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.