-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add realtime scheduling calls to std.os.linux (issue #19671) #19675
base: master
Are you sure you want to change the base?
Conversation
Looks good with a few minor adjustments. If you feel like it, it would be nice to also have these:
But that's not required to merge this, so if you don't feel like it, that's totally fine. 🙂 |
@curuvar do you think you'll be able to address my review comments soon? If you don't have time, that's totally fine; I can make the adjustments in that case. |
I’ll make the changes.
… On 12 Nov 24, at 16:16, Alex Rønne Petersen ***@***.***> wrote:
@curuvar <https://github.com/curuvar> do you think you'll be able to address my review comments soon? If you don't have time, that's totally fine; I can make the adjustments in that case.
—
Reply to this email directly, view it on GitHub <#19675 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOAJTISOP6SW53SI2ZWORHD2AJV2BAVCNFSM6AAAAABGLQDXRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRGU4TSOBRG4>.
You are receiving this because you were mentioned.
|
I made the requested changes and added: sched_getcpu and "getcpu" as it was needed for sched_getcpu. |
Nice, thanks! Just a couple of naming nitpicks and I think this one is good to go. |
Add the following system calls to std.os.linux:
Also add required sched_param structure and SCHED constant definitions:
Closes #19671.