Remove unused buf field from std.fmt.Parser
#21994
Open
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raindev
force-pushed
the
improve-std.fmt.Parser
branch
from
3646d56
to
b5dada8
Compare
And make the initialization less error prone by removing a default for iter, which is required for a functional parser
raindev
force-pushed
the
improve-std.fmt.Parser
branch
from
b5dada8
to
e704233
Compare
raindev
changed the title
buf field from std.fmt.Parser
mnemnion
suggested changes
Nov 15, 2024
lib/std/fmt.zig
Outdated
| @@ -311,10 +310,11 @@ pub const Specifier = union(enum) { | |||
| named: []const u8, | |||
| }; | |||
|
|
|||
| /// Intended for parsing std.fmt format strings without having to replicate the | |||
There was a problem hiding this comment.
A doc comment should be about the functionality of the commented variable, rather than about its intention.
Something like "A stream based parser for format strings", perhaps.
But "what this does" rather than "why this is here".
There was a problem hiding this comment.
Updated the doc to "what-this-is" followed by "when-to-use" 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make the initialization less error prone by removing a default for
iter, which is required for a functional parser.