Support configuration of entity reporting for V2 quirks #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #254 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 61 61
Lines 9388 9395 +7
=======================================
+ Hits 9044 9051 +7
Misses 344 344 ☔ View full report in Codecov by Sentry. |
|
needs a rebase |
benbancroft
force-pushed
the
v2_reporting
branch
from
208b149
to
cb75788
Compare
|
@dmulcahey I've just force pushed a rebase. The tests will continue to fail however, as this patch has dependeny on the zigpy PR, so this will require a further rebase once that merges. |
My bad.. sorry for the unnecessary ping!! |
Note: this requires zigpy export for exposing this via V2 quirk API.
benbancroft
force-pushed
the
v2_reporting
branch
from
cb75788
to
b9267d7
Compare
|
I've just rebased against zigpy dependency update. All tests should now be passing. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This change hooks up the V2 Quirk
report_configoption to the cluster handler created for V2 quirks. It also 'claims' the cluster, which is required for reporting and binding hooks to work upon configuration of the cluster and previously wasn't being done for V2 Quirk clusters.Additional information
Please refer to zigpy/zigpy#1490 for more information on the motivation behind this patch. This patch will need to be merged after that has been merged and zigpy dependency has been bumped.