Consolidate device diagnostics and create a tool to regenerate them #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert unnecessary change
Dump the node descriptor Ensure the output is stable Ensure the output is stable
puddly
force-pushed
the
puddly/combined-diagnostics
branch
from
9e2c905
to
664951c
Compare
|
Everything works but with a small problem: clusters that modify the state (e.g. double battery percentage) modify it globally, so running the tool keeps doubling them after re-load. We'll need to restore entity state after loading device info, it seems. Fixed with 9f4fe5b. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #284 +/- ##
==========================================
+ Coverage 96.33% 96.35% +0.02%
==========================================
Files 61 61
Lines 9388 9448 +60
==========================================
+ Hits 9044 9104 +60
Misses 344 344 ☔ View full report in Codecov by Sentry. |
dmulcahey
reviewed
Nov 1, 2024
dmulcahey
reviewed
Nov 1, 2024
dmulcahey
reviewed
Nov 1, 2024
dmulcahey
reviewed
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the logic from HA Core, this library, and https://github.com/dmulcahey/zha-device-exporter/ into a single method:
Device.get_diagnostics_json().