Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong return value of onnx similarity evaluation #460

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Jun 29, 2023

issue: #459 #386

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #460 (234662d) into dev (de35ae6) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #460      +/-   ##
==========================================
- Coverage   94.02%   93.99%   -0.03%     
==========================================
  Files          92       92              
  Lines        3583     3583              
==========================================
- Hits         3369     3368       -1     
- Misses        214      215       +1     
Impacted Files Coverage Δ
gptcache/manager/scalar_data/manager.py 90.47% <0.00%> (-4.77%) ⬇️
gptcache/processor/post.py 100.00% <ø> (ø)
gptcache/similarity_evaluation/distance.py 100.00% <ø> (ø)
gptcache/adapter/adapter.py 87.32% <100.00%> (ø)
gptcache/similarity_evaluation/onnx.py 95.83% <100.00%> (ø)
gptcache/utils/softmax.py 100.00% <100.00%> (ø)

@SimFG SimFG merged commit 4e5fad2 into zilliztech:dev Jun 29, 2023
sunilkumardash9 pushed a commit to sunilkumardash9/GPTCache that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants