-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCS native support (GCS implemented using Google Cloud Storage libraries) #495
base: main
Are you sure you want to change the base?
Conversation
@gifi-siby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
dfff96f
to
679134d
Compare
I noticed that in your PR for the GCP Native client, you implemented hierarchical deletion for files. Has GCP encountered similar deletion error issues as Azure? I’d like to understand the reasoning behind your choice of hierarchical deletion. |
In GCP, I didn't face the issue, but I adopted the same deletion method as in Azure as a precautionary measure. The function RemoveWithPrefix removes the objects in a way that respects the hierarchy of the storage, meaning it starts by deleting the deepest files first and works its way up. It uses goroutines to delete objects in parallel. |
Signed-off-by: gifi-siby <[email protected]> Signed-off-by: “gifi-siby” <[email protected]>
679134d
to
c952acd
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gifi-siby The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Any update on this PR? |
Native support for Google cloud storage using the Google Cloud Storage libraries. Authentication is performed using GCS service account credentials JSON.
Milvus supports GCS native and Milvus-Backup doesn't. Since Milvus supports GCS native, this enhancement is needed.
Related Issue: #444
PRs worked together are:
#494
#496