Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact block cache pt3 #170

Merged
merged 16 commits into from
Feb 6, 2025
Merged

Compact block cache pt3 #170

merged 16 commits into from
Feb 6, 2025

Conversation

idky137
Copy link
Contributor

@idky137 idky137 commented Jan 27, 2025 •
edited
Loading

Final integration of the Compact Block Cache.

  • Adds BlockCache to FetchService and uses BlockCache block fetch methods.
  • Updates DB to use big-endian bytes for height instead of Height(u32) (zebra-chain). This is required to search LMDB height keys by order.
  • Moves startup sync from FetchService::Spawn to BlockCache::Spawn.

@idky137 idky137 added the ZGM2 Issues that need to be resolved for the completion of the Zaino dev grant milestone 2 label Jan 29, 2025
@idky137 idky137 marked this pull request as ready for review January 29, 2025 14:17
@idky137 idky137 requested review from zancas and AloeareV January 29, 2025 14:17
@idky137 idky137 marked this pull request as draft January 30, 2025 13:26
@idky137 idky137 marked this pull request as ready for review January 30, 2025 13:42
@idky137 idky137 mentioned this pull request Jan 30, 2025
Merged
pacu
pacu requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some remarks and requests! Pretty exciting step forward!

@pacu pacu mentioned this pull request Jan 30, 2025
Closed
This was referenced Feb 4, 2025
Merged
Merged
zancas
zancas reviewed Feb 4, 2025
View reviewed changes
AloeareV
AloeareV previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@AloeareV AloeareV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Approved, once the conversations are resolved!

pacu
pacu previously approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me provided those small typos are addressed :)

@AloeareV AloeareV self-requested a review February 6, 2025 19:13
@AloeareV AloeareV merged commit 22c51f0 into zingolabs:dev Feb 6, 2025
5 of 12 checks passed
@pacu pacu mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas left review comments

@AloeareV AloeareV AloeareV approved these changes

@pacu pacu pacu left review comments

Assignees
No one assigned
Labels
ZGM2 Issues that need to be resolved for the completion of the Zaino dev grant milestone 2
Projects
Zaino - MileStone 2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idky137 @pacu @zancas @AloeareV