Docker builds and optimized CI workflow #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a Docker build process for Zaino which pushes successful builds to Docker Hub.
The push to Docker Hub only occurs when a git tag is created. The secrets DOCKERHUB_USERNAME and DOCKERHUB_TOKEN will need to be set on this repository for the push functionality to work.
Optionally a Github Release can be automatically created upon tag, which will require the secret GITHUB_TOKEN to be set on this repository.
The action runner can be optionally specified by setting the RUNNER_TYPE variable on this repository.
The Dockerfile caches dependencies for each crate to speed up subsequent builds. The CI workflow should also cache.
Zec.rocks is working towards using these builds to deploy Zaino infrastructure for testing. I welcome feedback and am happy to make adjustments as required.