Regexp mem opt #119
Open
Regexp mem opt #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for raredocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 92.53% 92.35% -0.19%
==========================================
Files 120 122 +2
Lines 6255 6315 +60
==========================================
+ Hits 5788 5832 +44
- Misses 346 359 +13
- Partials 121 124 +3 ☔ View full report in Codecov by Sentry. |
zix99
commented
Feb 22, 2025
| @@ -7,6 +7,7 @@ type Factory interface { | |||
|
|
|||
| // A non-thread-safe matcher that can be used to find matches | |||
| type Matcher interface { | |||
| FindSubmatchIndex(b []byte) []int | |||
| FindSubmatchIndexDst(b []byte, dst []int) []int | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize all matchers into zero-allocs by using passed-in buffer
I've been doing a ton of benchmarking on this, and while it does save some allocs, it actually seems to increase frozen GC time and net-neutral on general runtime. Benchmarks on a regex itself does have significant savings, so it does seem counter-intuitive.
There's more to figure out here before/if merging.