fix iOS segment adTracking issue

zk-passport · Jan 21, 2025 · 8882422 · 8882422
1 parent 44296d1
commit 8882422
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 26 deletions.
diff --git a/app/App.tsx b/app/App.tsx
@@ -10,24 +10,63 @@ import * as amplitude from '@amplitude/analytics-react-native';
 import { AMPLITUDE_KEY, SEGMENT_KEY } from '@env';
 import { useToastController } from '@tamagui/toast';
 import { YStack } from 'tamagui';
-import { createClient } from '@segment/analytics-react-native';
-import { requestTrackingPermission } from 'react-native-tracking-transparency';
+import { createClient, EventPlugin, PluginType, SegmentEvent } from '@segment/analytics-react-native';
 
 import MainScreen from './src/screens/MainScreen';
 import useNavigationStore from './src/stores/navigationStore';
 import useUserStore from './src/stores/userStore';
 import { bgWhite } from './src/utils/colors';
 import { setupUniversalLinkListener } from './src/utils/qrCode'; // Adjust the import path as needed
 
-// Remove the segment client creation from here
-// Instead export a function to create it
-export const createSegmentClient = () =>
-  SEGMENT_KEY ? createClient({
+export class DisableTrackingPlugin extends EventPlugin {
+  type = PluginType.before;
+
+  execute(event: SegmentEvent): SegmentEvent {
+    // Ensure context exists
+    if (!event.context) {
+      event.context = {};
+    }
+
+    // Ensure device context exists
+    if (!event.context.device) {
+      event.context.device = {};
+    }
+
+    // Force tracking related fields to be disabled
+    event.context.device.adTrackingEnabled = false;
+    event.context.device.advertisingId = undefined;
+    event.context.device.trackingStatus = 'not-authorized';
+    event.context.device.id = undefined;
+
+    return event;
+  }
+}
+
+export const createSegmentClient = () => {
+  if (!SEGMENT_KEY) return null;
+
+  const client = createClient({
     writeKey: SEGMENT_KEY,
     trackAppLifecycleEvents: true,
     trackDeepLinks: true,
     debug: true,
-  }) : null;
+    collectDeviceId: false,
+    flushAt: 20,
+    defaultSettings: {
+      integrations: {
+        'Segment.io': {
+          apiKey: SEGMENT_KEY,
+          trackApplicationLifecycleEvents: false,
+          trackDeepLinks: false,
+        }
+      }
+    }
+  });
+
+  client.add({ plugin: new DisableTrackingPlugin() });
+
+  return client;
+};
 
 // Export the client variable (will be initialized later)
 export let segmentClient: ReturnType<typeof createClient> | null = null;
@@ -55,21 +94,8 @@ function App(): React.JSX.Element {
   }, []);
 
   useEffect(() => {
-    const requestTracking = async () => {
-      if (Platform.OS === 'ios') {
-        const status = await requestTrackingPermission();
-        console.log('Tracking permission status:', status);
-        // Initialize segment client after getting tracking permission
-        if (status === 'authorized') {
-          segmentClient = createSegmentClient();
-        }
-      } else {
-        // On Android, initialize directly
-        segmentClient = createSegmentClient();
-      }
-    };
-
-    requestTracking();
+    // Initialize segment directly without any tracking checks
+    segmentClient = createSegmentClient();
   }, []);
 
   return (

diff --git a/app/ios/OpenPassport.xcodeproj/project.pbxproj b/app/ios/OpenPassport.xcodeproj/project.pbxproj
@@ -857,7 +857,10 @@
 					"-DFOLLY_MOBILE=1",
 					"-DFOLLY_USE_LIBCPP=1",
 				);
-				OTHER_LDFLAGS = "$(inherited)  ";
+				OTHER_LDFLAGS = (
+					"$(inherited)",
+					" ",
+				);
 				REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
 				SDKROOT = iphoneos;
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
@@ -947,7 +950,10 @@
 					"-DFOLLY_MOBILE=1",
 					"-DFOLLY_USE_LIBCPP=1",
 				);
-				OTHER_LDFLAGS = "$(inherited)  ";
+				OTHER_LDFLAGS = (
+					"$(inherited)",
+					" ",
+				);
 				REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
 				SDKROOT = iphoneos;
 				USE_HERMES = false;

diff --git a/app/ios/OpenPassport/Info.plist b/app/ios/OpenPassport/Info.plist
@@ -2,8 +2,6 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>NSUserTrackingUsageDescription</key>
-	<string>✨Help us improve the NFC passport reading experience. We only collect anonymous technical data to make passport scanning faster and more reliable for everyone.</string>
 	<key>CFBundleDevelopmentRegion</key>
 	<string>en</string>
 	<key>CFBundleDisplayName</key>