Skip to content
This repository has been archived by the owner on Aug 17, 2019. It is now read-only.

fix(checkDepEnvs): always install root pkg #60

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

larsgw
Copy link

@larsgw larsgw commented Nov 1, 2018

Always 'install' the root package, instead of ignoring it when --only=dev is passed.

See https://npm.community/t/3068

Always 'install' the root package, instead of ignoring it when 
--only=dev is passed.

See https://npm.community/t/3068
@heidemn
Copy link

heidemn commented Feb 8, 2019

Just encountered this bug in the wild... Why is nobody merging this PR?

tail -1 /etc/lsb-release && node --version && npm --version && npm ci --only=development
DISTRIB_DESCRIPTION="Ubuntu 18.04.1 LTS"
v10.15.1
6.7.0
added 0 packages in 0.028s

On the other side, NODE_ENV=development seems to be ignored, and installs all dependencies.
Both NODE_ENV=production and --only=production work.

Same behavior using Docker image "node:10-alpine".

The docs for "npm ci" neither mention "--only", nor NODE_ENV. So maybe it works as intended ;-)

@jbinard
Copy link

jbinard commented Feb 13, 2019

I'm also facing this issue. Can somebody approve this merge request to fix this annoying issue ?

Thanks

@JeremyCraigMartinez
Copy link

Can we please get this merged? Does anyone have a work around for installing devDependencies when your NODE_ENV=production in the meantime? Guessing NODE_ENV=local npm ci will suffice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants