Skip to content

Commit

Permalink
addressed all todos
Browse files Browse the repository at this point in the history
  • Loading branch information
phillip-stephens committed May 22, 2024
1 parent 0c90095 commit ff2e0e3
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cmd/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type CLIConf struct {
NameServersString string
LocalAddrString string
LocalIfaceString string
ConfigFilePath string // TODO Phillip - implement/ figure out what this is
ConfigFilePath string
ClassString string
UseNanoseconds bool
ClientSubnetString string
Expand Down
2 changes: 0 additions & 2 deletions pkg/zdns/lookup.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,6 @@ func (r *Resolver) retryingLookup(q Question, nameServer string, recursive bool)
} else {
origTimeout = r.tcpClient.Timeout
}
// TODO - Phillip it feels like bad practice to change the timeout value of the client without user input, should return an error/log msg and exit
// Leaving as a separate task so as not to refactor AND change functionality
defer func() {
// set timeout values back to original
if r.udpClient != nil {
Expand Down
1 change: 0 additions & 1 deletion pkg/zdns/qa.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ type TraceStep struct {
Try int `json:"try" groups:"trace"`
}

// TODO Phillip - many of these fields aren't being used, we should consider removing them or populating them
// Result contains all the metadata from a complete lookup, potentailly after following many CNAMEs/etc.
type Result struct {
AlteredName string `json:"altered_name,omitempty" groups:"short,normal,long,trace"`
Expand Down
1 change: 1 addition & 0 deletions pkg/zdns/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ func VerifyAddress(ansType string, ip string) bool {
return isIpv6
}
// TODO Phillip - this seems like strange behavior. Maybe assert that ansType is either 'A' or 'AAAA'?
// I'll come back to this post-merge, it was like this in the original version.
return !isIpv4 && !isIpv6
}

Expand Down

0 comments on commit ff2e0e3

Please sign in to comment.