Raise a warning log msg when overriding the user's selected --local-addr
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nk-local resolver, they'll use a link-local ip address, regardless of what they specifified
zakird
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #481
ZDNS tries to ensure that its config is valid before resolving. The default
--name-serverscome from/etc/resolv.conf. If that--name-serveris a link-local IP address, we'll override whatever--local-addris provided so we can reach the nameserver.In this case, #481 was rightfully confused when this behavior was not made apparent to the user. But elevating this to a
warn, we can inform the user of what we're doing, and they can select a new--name-serversif they need.