refactor(shields): MurphPad

[lesshonor]

• Added matrix transforms and physical layouts for three configurations. This is a numpad, but notably the first three positions of column 0 are actually tact switches on the back of the PCB. I believe the new transforms make this clearer (the keymap appearance matches QMK Configurator now, too)
• Tweaked default keymap:
  • more closely resembles the QMK Configurator default map (reduces confusion for users who are new to ZMK; also generally less niche)
  • more useful OOTB for ZMK (immediate access to output selection, easier BT profile switching).
• Cleaned up formatting a bit.
• Updated encoder configuration to current ZMK standards.
• Avoid forcing RGB on for nice_nano.
• Corrected the number of default LEDs. While some users may opt for less or more, there are exactly eight footprints on the PCB for 5050 SMD LEDs.

Board/Shield Check-list

• This board/shield is tested working on real hardware
• General consistent formatting of DeviceTree files
• Keymaps do not use deprecated key defines (Check using the upgrader tool)

[caksoylar]

I had noticed the discrepancies when comparing vs. the configurator, looks good to me.

[Nick-Munnich]

Looking at this the only point I want to raise is that it has OLED defaulting to y. Imo OLED/RGB/Display etc. should always be opt-in, rather than opt-out.

[lesshonor]

Looking at this the only point I want to raise is that it has OLED defaulting to y. Imo OLED/RGB/Display etc. should always be opt-in, rather than opt-out.

I would agree with you on most shields. On this one: yes, you can opt out of the display, but the plate will have an unsightly hole in it unless you modify the plate file and get that alternate version cut. I've probably assisted with some fifty MurphPad builds in one way or another; plenty didn't bother with RGB or encoders, but no one has ever not installed the display...even if assembly errors meant they couldn't get it working.
...That said, I still wanted to facilitate the option just in case—hence "enabling the OLED in a less-authoritarian way".
I'd do the same for the encoder if that was actually possible.

[Nick-Munnich]

I would agree with you on most shields. On this one: yes, you can opt out of the display, but the plate will have an unsightly hole in it unless you modify the plate file and get that alternate version cut. I've probably assisted with some fifty MurphPad builds in one way or another; plenty didn't bother with RGB or encoders, but no one has ever not installed the display, even if they couldn't get it working. ...That said, I still wanted to facilitate the option just in case—hence "enabling the OLED in a less-authoritarian way". I'd do the same for the encoder if that was actually possible.

That's a fair argument. I think I'd still prefer explicit for consistency with other devices, though. We need to improve our related documentation on it too. I didn't actually notice that the encoder stuff wasn't commented out, I'd obviously be in favor of doing that too.

All that said I am perfectly happy to be overruled in this case.

[petejohanson]

LGTM!