Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bt): Add new experimental testing Kconfig setting. #2057

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Dec 4, 2023

  • In order to have an easy way to test and phase in BT changes, add a
    new ZMK_BLE_EXPERIMENTAL_FEATURES Kconfig setting.

@petejohanson petejohanson requested a review from a team as a code owner December 4, 2023 19:11
@petejohanson petejohanson self-assigned this Dec 4, 2023
@petejohanson petejohanson added enhancement New feature or request bluetooth Bluetooth related items labels Dec 4, 2023
@joelspadin
Copy link
Collaborator

By calling this "beta testing", I worry it might be confused with https://zmk.dev/docs/features/beta-testing. What do you think about something more like CONFIG_ZMK_BLE_EXPERIMENTAL_FEATURES? Alternatively, we could add a section to the beta testing page that shows how to enable this flag.

@petejohanson
Copy link
Contributor Author

By calling this "beta testing", I worry it might be confused with https://zmk.dev/docs/features/beta-testing. What do you think about something more like CONFIG_ZMK_BLE_EXPERIMENTAL_FEATURES? Alternatively, we could add a section to the beta testing page that shows how to enable this flag.

Not a bad idea to clearly differentiate these two things. Not sure I want to add to the beta-testing page... That's nicely focused right now.

* In order to have an easy way to test and phase in BT changes, add a
  new `ZMK_BLE_EXPERIMENTAL_FEATURES` Kconfig setting.
@petejohanson petejohanson force-pushed the bluetooth/add-beta-testing-option branch from 5b2a5f7 to 47d1bed Compare December 5, 2023 00:05
@petejohanson petejohanson changed the title feat(bt): Add new beta testing Kconfig setting. feat(bt): Add new experimental testing Kconfig setting. Dec 5, 2023
@petejohanson petejohanson merged commit 0ab6a0a into zmkfirmware:main Dec 6, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluetooth Bluetooth related items enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants