Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two performance tweaks for the GHA build workflow:
yaml2json | jq
withyq
. This saves the installation step shaving off a few more seconds.The following table summarizes the performance impact for building a
reviung41
with the stock config on ZMKv0.1
.(See https://github.com/urob/zmk-build-benchmarks/actions for the benchmarks.)
Note
The dependency change is most impactful on cold caches. As Github caches expire after 7 days this should be a nice speed up for many
build-user-config
workflow runs.For the upstream repo the gains are more limited since the cache should rarely be cold. On the other hand, there isn't really a downside since none of the workflows interacts with trees that aren't reachable from
HEAD
. For now I also applied the tweak to the ZMKbuild
andtest
workflows but happy to revert that.PR check-list