Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combos): Add require-prior-idle-ignore #2768

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ssbb
Copy link

@ssbb ssbb commented Jan 15, 2025

Some keys do not add any value to require-prior-idle-ms. The most obvious example is Space - you can't rely on Space for RPI because you can start typing with the same word (eg with combo on OU with RPI it won't trigger when you type the output but will trigger when you start typing with just output).

require-prior-idle makes the most sense for rolls that do not appear at the start of a word, such as ND. However, imagine you have a combo that outputs = at this position and want to type myvar = something. You would need to wait after pressing Space, which does not make sense. Ignoring Space here is reasonable because [space]ND is not something you typically want to type.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@ssbb ssbb force-pushed the combos-require-prior-idle-ignore branch from ec0be3e to 4476e9b Compare January 15, 2025 08:39
@ssbb ssbb marked this pull request as ready for review January 15, 2025 08:40
@ssbb ssbb requested review from a team as code owners January 15, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant