feat(combos): Add require-prior-idle-ignore #2768
Open
+132
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some keys do not add any value to
require-prior-idle-ms
. The most obvious example is Space - you can't rely on Space for RPI because you can start typing with the same word (eg with combo onOU
with RPI it won't trigger when you typethe output
but will trigger when you start typing with justoutput
).require-prior-idle
makes the most sense for rolls that do not appear at the start of a word, such as ND. However, imagine you have a combo that outputs=
at this position and want to typemyvar = something
. You would need to wait after pressing Space, which does not make sense. Ignoring Space here is reasonable because[space]ND
is not something you typically want to type.PR check-list