choo: factor out library pieces, add arbitrary arg #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litlep-nibbyt
force-pushed
the
jyw/extends
branch
from
779203c to
2bd1dde
Compare
eamsden
requested changes
Jan 31, 2025
Comment on lines
-143
to
-176
| pub mod test { | ||
| use super::*; | ||
| use tokio::fs; | ||
| use tracing::info; | ||
|
|
||
| pub async fn test_nockapp( | ||
| entry: std::path::PathBuf, | ||
| deps_dir: std::path::PathBuf, | ||
| ) -> Result<crown::nockapp::NockApp, Error> { | ||
| let cli = ChooCli { | ||
| boot: BootCli { | ||
| save_interval: 1000, | ||
| new: false, | ||
| trace: false, | ||
| log_level: "trace".to_string(), | ||
| color: ColorChoice::Auto, | ||
| state_jam: None, | ||
| }, | ||
| entry, | ||
| directory: deps_dir, | ||
| arbitrary: false, | ||
| }; | ||
| initialize_nockapp(cli).await | ||
| } | ||
|
|
||
| pub async fn test_build(nockapp: &mut crown::nockapp::NockApp) -> Result<(), Error> { | ||
| nockapp.run().await?; | ||
| // TODO this doesn't work because choo exits when compilation is done. | ||
| // Verify output file exists and is not empty | ||
| let metadata = fs::metadata("out.jam").await?; | ||
| info!("Output file size: {} bytes", metadata.len()); | ||
| assert!(metadata.len() > 0, "Output file is empty"); | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
why are we deleting the tests?
There was a problem hiding this comment.
We aren't deleting the tests, these are functions that I moved out of the test module because they're used to build jams, possibly outside of tests. @bitemyapp is there a specific reason why you have them in the test module?
apps/choo/tests/build.rs
Outdated
| @@ -1,4 +1,5 @@ | |||
| use choo::test::*; | |||
| use choo::{initialize_nockapp_, run_build}; | |||
| use crown::kernel::boot::default_boot_cli; | |||
| use tracing::{debug, info}; | |||
|
|
|||
| // TODO: Move this to an integration test. | |||
There was a problem hiding this comment.
can this comment go away now?
There was a problem hiding this comment.
No, but I can make the change to move them to integration tests in this PR
There was a problem hiding this comment.
Nevermind, it already is. I was looking at this on my phone. Will delete comment now
eamsden
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.