fix incomplete coverage

zostay · Jul 14, 2023 · e4aba95 · e4aba95
1 parent a08ffdd
commit e4aba95
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/Changes.md b/Changes.md
@@ -2,6 +2,7 @@ WIP  TBD
 
  * Added slices.FirstIndex and slices.GrepIndex.
  * Added set.NewSized and set.Diff.
+ * Fixed missing test coverage on generic.FirstNonNil and generic.FirstNonZero.
 
 v0.2.0  2023-07-08
 

diff --git a/generic/value_test.go b/generic/value_test.go
@@ -12,6 +12,7 @@ func TestFirstNonZero(t *testing.T) {
 	assert.Equal(t, 1, generic.FirstNonZero[int](0, 1, 2))
 	assert.Equal(t, 1, generic.FirstNonZero[int](1, 0, 2))
 	assert.Equal(t, 1, generic.FirstNonZero[int](0, 0, 1))
+	assert.Equal(t, 0, generic.FirstNonZero[int](0, 0, 0))
 }
 
 func TestFirstNonNil(t *testing.T) {
@@ -24,6 +25,7 @@ func TestFirstNonNil(t *testing.T) {
 	assert.Equal(t, *b, *generic.FirstNonNil(a, b, c))
 	assert.Equal(t, *b, *generic.FirstNonNil(b, a, c))
 	assert.Equal(t, *b, *generic.FirstNonNil(a, a, b))
+	assert.Nil(t, generic.FirstNonNil[int](nil, nil, nil))
 }
 
 func TestZero(t *testing.T) {