initial aria-live setup for search results + annotations #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mrtcode
reviewed
Jun 27, 2024
src/common/components/reader-ui.js
Outdated
| @@ -192,6 +192,7 @@ const ReaderUI = React.forwardRef((props, ref) => { | |||
| {state.passwordPopup && <PasswordPopup params={state.passwordPopup} onEnterPassword={props.onEnterPassword}/>} | |||
| {state.printPopup && <PrintPopup params={state.printPopup}/>} | |||
| {state.errorMessage && <div className="error-bar" tabIndex={-1}>{state.errorMessage}</div>} | |||
| <div id="a11tyAnnouncement" aria-live='polite'></div> | |||
There was a problem hiding this comment.
We use double quotes for HTML attributes.
- added aria-live container to reader ui - during keyboard navigation through annotations or when going through search results, set a message inside of the aria-live container to have screen readers announce them - this should satisfy vpat 75 and 78 issues Addresses: zotero/zotero#4223
abaevbog
added a commit
to abaevbog/zotero
that referenced
this pull request
Jun 27, 2024
used to announce which annotation is selected during keyboard navigation, as well as the index of the current search result Followup to zotero/reader#130
dstillman
pushed a commit
to zotero/zotero
that referenced
this pull request
Jul 2, 2024
used to announce which annotation is selected during keyboard navigation, as well as the index of the current search result Followup to zotero/reader#130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sse
aria-livefield to announce annotations and search results when they are being switched between with keyboard.Demo