EPUB appearance: Add 'Use original font' and 'Page width' options, increase zoom limit #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I try to build this it keeps throwing npm error, but from the screenshot it looks fine. I think putting icons here while all other sliders use text labels might be weird. I'm not sure how page width is calculated, but what if we just display a percentage, so that the widest is 100% and the narrowest is e.g. 50%? |
|
Full is just unlimited, so however wide the window is, that's how wide the page will be (minus text margins). |
|
But percentages seem fine - doesn't really have to be exact, but it gets the point across. |
|
@dstillman: OK to merge? I can add the strings in zotero/zotero before updating submodules. |
Fixes pagination issue in documents with saved appearance states.
dstillman
pushed a commit
that referenced
this pull request
Jul 31, 2024
dstillman
pushed a commit
that referenced
this pull request
Jul 31, 2024
dstillman
pushed a commit
that referenced
this pull request
Jul 31, 2024
Fixes pagination issue in documents with saved appearance states.
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this:
If we had some "narrow"/"normal"/"full" icons, we could use them for the page width slider, but I don't think that's essential, and a textual label felt like overkill.
Addresses zotero/zotero#4456 and zotero/zotero#4457