Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIND ILS: Add 269, 720 fields #3413

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

TIND ILS: Add 269, 720 fields #3413

wants to merge 3 commits into from
+235 −90

Conversation

skairunner
Copy link

@skairunner skairunner commented Jan 29, 2025 •
edited
Loading

  • Include 720 in the list of fields considered as creators. It is used by e.g. Social Media Archive to list contributors.
  • Refactor MARCXML importer to expose a utility function that can be manually driven, similar to the MARC importer.
  • Use the MARCXML importer in TIND ILS to fetch dialect-specific non-standard MARC information, i.e. the use of 269 as a date.

This PR will remain a draft until #3409 is merged for two reasons:

  • The 720 creators should be contributors, but some code in the MARC importer converts all creators to editors if there is no author and item type is book. All TIND item types are currently set to book. The above PR fixes this.
  • All the old tests are broken and are fixed in Library Catalog (TIND ILS): Enrich item type from Schema.org #3409.

@skairunner
MARC: Map 720 as a contributor
60c1bbb 
- 720 fields are sometimes used e.g. in datasets to describe additional
  contributors.
- Use 720 field as a contributor.
- Note that tests will fail until zotero#3409 is merged. This is because the
  MARC code assumes that all books with no authors that have
  contributors are actually meant to be editors, which is invalid.
  However, we have no way of setting items to be not Book without zotero#3409.
@skairunner
MARCXML: Refactor to expose a utility.
dbb1a73 
- Refactor MARCXML importer to expose a utility function, similar to
  the MARC importer. This will allow consumers of the MARCXML translator
  to instead decide to manually drive the process.
@skairunner
TIND ILS: Use 269 for date
5a4a049 
- Convert to using the MARCXML utility function directly
- Use the MARCXML utility to read date from the 269 field, which is a
  non-standard MARC field.
@AbeJellinek
Copy link
Member

#3409 is merged, so go ahead and rebase!

@skairunner
Copy link
Author

Will do, out sick for the moment so it might be a bit 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skairunner @AbeJellinek