Fix for pdf-worker not working in beta build due to ‘$isDebug’ value …

…being passed as js string instead of boolean from Kotlin side to WebView resulting in an incorrect paths to be used for pdf worker js files. Upping versionCode to 133
zotero · Feb 11, 2025 · 0b05abf · 0b05abf
1 parent 0bca587
commit 0b05abf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/src/main/java/org/zotero/android/pdfworker/web/PdfWorkerWebCallChainExecutor.kt b/app/src/main/java/org/zotero/android/pdfworker/web/PdfWorkerWebCallChainExecutor.kt
@@ -139,7 +139,7 @@ class PdfWorkerWebCallChainExecutor(
         pdfFileName: String,
     ) {
         return suspendCancellableCoroutine { cont ->
-            pdfWorkerWebViewHandler.evaluateJavascript("javascript:recognizePdf('${BuildConfig.DEBUG}', '${pdfFilePath}', '${pdfFileName}')") {
+            pdfWorkerWebViewHandler.evaluateJavascript("javascript:recognizePdf(${BuildConfig.DEBUG}, '${pdfFilePath}', '${pdfFileName}')") {
                 cont.resume(Unit)
             }
         }

diff --git a/buildSrc/src/main/kotlin/BuildConfig.kt b/buildSrc/src/main/kotlin/BuildConfig.kt
@@ -4,7 +4,7 @@ object BuildConfig {
     const val compileSdkVersion = 34
     const val targetSdk = 34
 
-    val versionCode = 132 // Must be updated on every build
+    val versionCode = 133 // Must be updated on every build
     val version = Version(
         major = 1,
         minor = 0,

diff --git a/scripts/bundle_pdf-worker.py b/scripts/bundle_pdf-worker.py
@@ -6,7 +6,7 @@
 import time
 import urllib.request
 
-commit_hash = "01901bf65e12741e727df38eaaa24a67d4fc6a5e"
+commit_hash = "897513ca6427e148d36c9105f1f54f5afc5e28f6"
 
 pdf_worker_download_url = "https://zotero-download.s3.amazonaws.com/ci/client-pdf-worker/" + commit_hash + ".zip"