New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url_metadata: fix an issue where Youtube returns 'undefined' as the canonical #104

Merged

mworrell merged 1 commit into master from youtube-canonical-undefined

Jan 10, 2025

Member

mworrell commented Jan 10, 2025 •

edited

Loading

Youtube sometimes returns:

<link rel="canonical" href="undefined">

This messes up the canonical_url metadata attribute.

Do not add metadata for the link and meta tags with undefined, "undefined" and "" values.


          url_metadata: fix an issue where Youtube returns 'undefined' as the c…

248f4af

…anonical

mworrell merged commit 980961a into master

3 checks passed

mworrell deleted the youtube-canonical-undefined branch

January 10, 2025 11:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet