Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Like named PDS members enhancement #2427

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

pujal0909
Copy link
Contributor

@pujal0909 pujal0909 commented Feb 3, 2025

What It Does

When copying PDSs, if the source and target have like-named members, the default behavior now is to prompt the user to confirm before overwriting the members contents (when the safe-replace option is not set to true). If the user uses the replace flag, it bypasses the prompt.

How to Test

  1. Copy a source PDS into a target PDS, with both having members with the same names.
  2. Notice that a prompt appears where you can select 'y/N'
  3. Now copy the same source PDS into the same target PDS with the replace option.
  4. Notice that the prompt is skipped

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Pujal <[email protected]>
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (9340db9) to head (059e305).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2427   +/-   ##
=======================================
  Coverage   91.36%   91.37%           
=======================================
  Files         639      639           
  Lines       18283    18301   +18     
  Branches     3923     3853   -70     
=======================================
+ Hits        16704    16722   +18     
  Misses       1577     1577           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pujal <[email protected]>
@pujal0909 pujal0909 marked this pull request as ready for review February 4, 2025 14:55
Copy link

github-actions bot commented Feb 4, 2025

📅 Suggested merge-by date: 2/18/2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

1 participant