add method to issue ssh commands #351
Conversation
olamidepeterojo
changed the title
olamidepeterojo
changed the title
There was a problem hiding this comment.
Hey @olamidepeterojo,
Thank you so much for this contribution 🙏
I think this is going to be super helpful for users that want to script their Unix commands via the python sdk 🙏
Apologies for the delay on reviewing this. I just wanted to share that there are a few things that I still need test here 🙏
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ All notable changes to the Zowe Client Python SDK will be documented in this fil | |||
|
|
|||
| - Turning off logger at the class-constructor level [#316](https://github.com/zowe/zowe-client-python-sdk/issues/316) | |||
| - Added support for commonly used environmental variables, like `REQUESTS_CA_BUNDLE` and `CURL_CA_BUNDLE`. [#346](https://github.com/zowe/zowe-client-python-sdk/issues/346) | |||
| - Add method to issue SSH commands. [#253](https://github.com/zowe/zowe-client-python-sdk/issues/253) | |||
There was a problem hiding this comment.
We should move this to a new section above 1.0.0-dev22 with a ## Recent Changes header. 😋
There was a problem hiding this comment.
Okay will do so 😋
requirements.txt
Outdated
| @@ -3,6 +3,7 @@ deepmerge==1.1.0 | |||
| jsonschema==4.17.3 | |||
| PyYAML==6.0.1 | |||
| requests==2.32.0 | |||
| paramiko | |||
There was a problem hiding this comment.
Thanks for choosing one of the recommended libraries mentioned by Timothy on the issue:
I'm wondering if we should lock this down to a specific version 🤔
There was a problem hiding this comment.
i was thinking version 3.5.0 which is the latest version
src/zos_uss/README.md
Outdated
There was a problem hiding this comment.
Thanks for adding documentation with a small example script. 😋
I believe this will make it easier for people to adopt going forward 🙏
Curious if we should mention some of the possible limitations in the readme...
Perhaps with commands that change codepages, or how the paramiko package may handle special characters (e.g. ööö, 👍 , 🔟 )
What about encoding? 🤔
These are some ideas of things we should probably consider in this document 🙏
There was a problem hiding this comment.
And last but not least, we should probably update the `read-the-docs as part of this PR 🙏
| """ | ||
|
|
||
| def __init__(self, connection: dict, log: bool = True): | ||
| super().__init__(connection, "/zosmf/restuss", logger_name=__name__, log=log) |
There was a problem hiding this comment.
I like the attempt at initializing the class 🙏
I'm afraidI couldn't find such endpoint on zosmf 😅
There was a problem hiding this comment.
my apologies.../zosmf/restfiles/fs should do the trick of finding the endpoint 😅
Signed-off-by: Olamide Ojo <[email protected]>
What It Does
Fixes #253
How to Test
Review Checklist
I certify that I have:
Additional Comments