-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to z/OS console panel #3445
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: JWaters02 <[email protected]>
Signed-off-by: JWaters02 <[email protected]>
…ling This meant replacing the deprecated vscode webviews component with raw html/css as that React library's components' stylings cannot be overriden Signed-off-by: JWaters02 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3445 +/- ##
==========================================
- Coverage 93.24% 93.24% -0.01%
==========================================
Files 120 120
Lines 12675 12674 -1
Branches 2864 2757 -107
==========================================
- Hits 11819 11818 -1
Misses 855 855
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Not sure what the changelog entry for this one should be since it's a few things bundled into one. |
Hey @JWaters02 can list them separated by comma or via bullet list if you would like, we can also add @anaxceron to help fine tune the changelog entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fixes LGTM! thanks @JWaters02
Signed-off-by: JWaters02 <[email protected]> chore: changelog Signed-off-by: JWaters02 <[email protected]>
58dd657
to
572f452
Compare
Proposed changes
There are 3 parts to this PR:
Release Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments
It's a funny coincidence that phaumer posted this suggestion of renaming the panel view after I had starting working on this PR 🙂