-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(TableViewProvider): make constructor & properties protected #3456
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
📅 Suggested merge-by date: 2/25/2025 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3456 +/- ##
==========================================
- Coverage 93.24% 93.24% -0.01%
==========================================
Files 120 120
Lines 12675 12674 -1
Branches 2864 2920 +56
==========================================
- Hits 11819 11818 -1
Misses 855 855
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
Signed-off-by: Trae Yelovich <[email protected]>
858aaf0
to
8d6e0fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the fix @traeok
Proposed changes
Updates access modifier for constructor and properties of
TableViewProvider
so it can be extended by extenders for their own panels.Release Notes
Milestone: 3.1.1 (or 3.2.0, no strong preference)
Changelog: No changelog needed as behavior is non-breaking & has no effect on current ZE logic
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment