Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(TableViewProvider): make constructor & properties protected #3456

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

traeok
Copy link
Member

@traeok traeok commented Feb 11, 2025

Proposed changes

Updates access modifier for constructor and properties of TableViewProvider so it can be extended by extenders for their own panels.

Release Notes

Milestone: 3.1.1 (or 3.2.0, no strong preference)

Changelog: No changelog needed as behavior is non-breaking & has no effect on current ZE logic

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Copy link

📅 Suggested merge-by date: 2/25/2025

@traeok traeok added the no-changelog Add to PR's that don't require a CHANGELOG update label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (8f9cc83) to head (9d5f600).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3456      +/-   ##
==========================================
- Coverage   93.24%   93.24%   -0.01%     
==========================================
  Files         120      120              
  Lines       12675    12674       -1     
  Branches     2864     2920      +56     
==========================================
- Hits        11819    11818       -1     
  Misses        855      855              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

t1m0thyj
t1m0thyj previously approved these changes Feb 11, 2025
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Signed-off-by: Trae Yelovich <[email protected]>
@traeok traeok force-pushed the tables/change-access-modifier branch from 858aaf0 to 8d6e0fc Compare February 13, 2025 16:10
@traeok traeok removed the no-changelog Add to PR's that don't require a CHANGELOG update label Feb 13, 2025
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix @traeok

@JillieBeanSim JillieBeanSim merged commit 1233383 into main Feb 14, 2025
26 checks passed
@JillieBeanSim JillieBeanSim deleted the tables/change-access-modifier branch February 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants