-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZE API for direct connect login/logout & adoption in ZE processes #3459
Conversation
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
==========================================
+ Coverage 93.25% 93.44% +0.18%
==========================================
Files 120 120
Lines 12692 12672 -20
Branches 2809 2806 -3
==========================================
+ Hits 11836 11841 +5
+ Misses 855 830 -25
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
📅 Suggested merge-by date: 3/3/2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
I love this for extenders! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks Billie!
Proposed changes
addresses #3346
created direct connect login and logout apis in ZE API and adopted them in ZE login and logout actions for profiles not using the
apimlAuthenticationToken
token typeRelease Notes
Milestone: 3.2.0
Changelog:
directConnectLogin
anddirectConnectLogout
to the ZoweVsCodeExtension class. #3346directConnectLogin
anddirectConnectLogout
methods for login and logout actions NOT using the tokenTypeapimlAuthenticationToken
. #3346Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments