Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZE API for direct connect login/logout & adoption in ZE processes #3459

Merged
merged 11 commits into from
Feb 18, 2025

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Feb 14, 2025

Proposed changes

addresses #3346

created direct connect login and logout apis in ZE API and adopted them in ZE login and logout actions for profiles not using the apimlAuthenticationToken token type

Release Notes

Milestone: 3.2.0

Changelog:

  1. ZE API - Added new directConnectLogin and directConnectLogout to the ZoweVsCodeExtension class. #3346
  2. ZE - Adopted ZE APIs new directConnectLogin and directConnectLogout methods for login and logout actions NOT using the tokenType apimlAuthenticationToken. #3346

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@JillieBeanSim JillieBeanSim added this to the v3.2.0 milestone Feb 14, 2025
@JillieBeanSim JillieBeanSim self-assigned this Feb 14, 2025
@JillieBeanSim JillieBeanSim linked an issue Feb 14, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.44%. Comparing base (53d3fd7) to head (cb00b72).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/zowe-explorer/src/configuration/Profiles.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3459      +/-   ##
==========================================
+ Coverage   93.25%   93.44%   +0.18%     
==========================================
  Files         120      120              
  Lines       12692    12672      -20     
  Branches     2809     2806       -3     
==========================================
+ Hits        11836    11841       +5     
+ Misses        855      830      -25     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JillieBeanSim JillieBeanSim marked this pull request as ready for review February 17, 2025 17:17
Copy link

📅 Suggested merge-by date: 3/3/2025

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

I love this for extenders! 🙏

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks Billie!

@JillieBeanSim JillieBeanSim merged commit 1afc79a into main Feb 18, 2025
34 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/zeapi-direct-token branch February 18, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

ZE API VSC login/logout APIs should support direct connect token
3 participants