Skip to content

Commit

Permalink
fix: Fixed ZIA Device Management Pagination (#305)
Browse files Browse the repository at this point in the history
  • Loading branch information
willguibr authored Feb 14, 2025
1 parent b0bd9f6 commit 1fd392f
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

# 3.1.6 (February 14, 2025)

## Notes
- Golang: **v1.22**

### Bug Fixes
[PR #305](https://github.com/zscaler/zscaler-sdk-go/pull/305) - Fixed ZIA device management function `GetDevicesByName` pagination, by removing duplicated pagination parameters.

# 3.1.5 (February 12, 2025)

## Notes
Expand Down
10 changes: 9 additions & 1 deletion docs/guides/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,18 @@ Track all Zscaler SDK GO releases. New resources, features, and bug fixes will b

---

``Last updated: v3.1.5``
``Last updated: v3.1.6``

---

# 3.1.6 (February 14, 2025)

## Notes
- Golang: **v1.22**

### Bug Fixes
[PR #305](https://github.com/zscaler/zscaler-sdk-go/pull/305) - Fixed ZIA device management function `GetDevicesByName` pagination, by removing duplicated pagination parameters.

# 3.1.5 (February 12, 2025)

## Notes
Expand Down
2 changes: 1 addition & 1 deletion zscaler/zia/services/devicegroups/devicegroups.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func GetDevicesByID(ctx context.Context, service *zscaler.Service, deviceID int)
func GetDevicesByName(ctx context.Context, service *zscaler.Service, deviceName string) (*Devices, error) {
var devices []Devices
// We are assuming this device name will be in the firsy 1000 obejcts
err := common.ReadAllPages(ctx, service.Client, fmt.Sprintf("%s?page=1&pageSize=1000", devicesEndpoint), &devices)
err := common.ReadAllPages(ctx, service.Client, (devicesEndpoint), &devices)
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 1fd392f

Please sign in to comment.