Tweak dark theme

[Gaurav-Kushwaha-1225]

About Changes

This PR updates the color variables in DesignVariables and MessageListTheme for a slightly higher contrast in dark theme according to the values in the figma file.

Fixes: #973

Screenshots

Before	After

[alya]

Please clean up your commit history and post again to request a review. See here for guidelines.

[Gaurav-Kushwaha-1225]

Please clean up your commit history and post again to request a review. See here for guidelines.

I’ve cleaned up the commit history by removing unnecessary merge commits into the TweakDarkTheme branch and combining related changes into a single commit for clarity.

This is my first time using rebase -i. During the process, I used pick, squash, and drop commands for various commits. I initially thought there would be separate commit messages for each, but later realized they were combined into one during the rebase.
Although, it asked to enter three commit messages after rebasing, Idk why it happened. Could you please explain why all commit messages were merged into one?
I’d like to understand this better for future contributions.

Apologies for any confusion.

Please review the updated PR.

[gnprice]

The #git help channel on chat.zulip.org is a good place to ask questions about using Git.

[Gaurav-Kushwaha-1225]

Please clean up your commit history and post again to request a review. See here for guidelines.

Hi @alya, please review the updated PR.

[alya]

Thanks! I'll let other folks take a look at this one.

[PIG208]

Hi! Please read through the commit style guide (also previously linked by Alya) linked in our README and fix the commit message: https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

[PIG208]

Thanks for the PR! I noted the differences between this revision and the Figma design after going through lib/widgets/message_list.dart and some part of lib/widgets/compose_box.dart for colors used in the widgets.

Some of the comments are just about different colors being used, and others request the addition/removal of variables. It should be fine to include color adjustments all in a single commit, but for adding/removing variables, let's try to have separate commits for the ones added, so it is easier to see which variables they replace. Consider using the NFC tag if a commit is a pure refactor.

I think there are also changes to the autocomplete window, but that should be addressed in #995,

[PIG208]

Thanks for the update! Left a comment. Could you also post the updated screenshots?

[Gaurav-Kushwaha-1225]

Screenshots of all Commits

It's ready for review now. The failing CI checks are due to some other change that is being discussed in the Zulip chats.

• Commit: 885f1fd, a4996d6 i.e. The Topic row icon color and background color of message.

Before	After

• Commits: c94e0e2, 752648f, 06a5138

Before	After

[alya]

What's going on with the dramatic changes at the bottoms of your screenshots?

[PIG208]

Apart from the issue Alya brought up, the update looks good to me! Marking this for Greg's review.

[Gaurav-Kushwaha-1225]

What's going on with the dramatic changes at the bottoms of your screenshots?

It seems to be a new issue in the main branch. When you change the theme after opening the app (for example, while on the DMs page), the bottom taskbar color doesn’t update properly.

Could you confirm if this issue persists? If so, I’ll check for an existing issue or file a new one.

Thanks for pointing it out!

[Gaurav-Kushwaha-1225]

What's going on with the dramatic changes at the bottoms of your screenshots?

Hi @alya, Thanks for pointing out the issue, I have filed an issue for this.
Issue: #1333