Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home: Show organization name and icon atop main menu #1313

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chimnayajith
Copy link

@chimnayajith chimnayajith commented Jan 30, 2025

Pull Request

Description

This PR implements the feature to display the current organization’s name and icon at the top of the main menu, as per the design in Figma here.

The organization name (realmName) and icon (realmIcon) are fetched from the initial snapshot and stored in PerAccountStore.

The "Organizations" button leads to the ChooseAccountPage.

Related Issues

Screenshots

imageimage

@PIG208 PIG208 added the maintainer review PR ready for review by Zulip maintainers label Jan 30, 2025
@chimnayajith chimnayajith force-pushed the 1037-show-org-name-icon-atop-menu branch 3 times, most recently from a130711 to 865b141 Compare February 5, 2025 16:51
@gnprice
Copy link
Member

gnprice commented Feb 6, 2025

Thanks @chimnayajith for picking this up!

These changes look pretty clean, so I'm hopeful this can be finished and merged without too much further work. And the feature is something we've heard requests for from users.

So although we're generally focusing on launch issues now, and this issue is post-launch, I think this PR can be one of the exceptions which we continue work on.

One thing it'll need before we give it a detailed review, though: some tests are failing, which you'll need to fix.

@gnprice gnprice added this to the M6: Post-launch milestone Feb 6, 2025
@chimnayajith chimnayajith force-pushed the 1037-show-org-name-icon-atop-menu branch from 865b141 to 47917ec Compare February 6, 2025 02:54
@chimnayajith chimnayajith force-pushed the 1037-show-org-name-icon-atop-menu branch from 47917ec to 8ba5c37 Compare February 6, 2025 03:21
@chimnayajith
Copy link
Author

@gnprice Fixed the failing tests. Please take a look.

@gnprice
Copy link
Member

gnprice commented Feb 6, 2025

Great, thanks. The next stage for this PR will be maintainer review:
https://zulip.readthedocs.io/en/latest/contributing/review-process.html#stages-of-a-pull-request-review

Maintainers will prioritize reviewing PRs for launch issues, so this one might sit idle for a while at times. Similarly, on your end please prioritize launch issues.

The thing you can do to help expedite this PR is to occasionally reread it while bearing in mind feedback you've gotten on other PRs, and try to spot places where similar feedback would apply. Then you can revise it accordingly, which will simplify later review.

@chimnayajith
Copy link
Author

Quoting from #1178

In the future this item will be replaced: #1037
but that may be post-launch, and this odd icon-less gap should be fixed before launch. Adding an icon here is trivial, once we pick an icon for it.

Should I remove the switch account option in the main menu as part of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show current organization's name and icon atop main menu
3 participants