Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msglist: Fix DM header color lerp bug. #1336

Merged
merged 1 commit into from
Feb 7, 2025
Merged

msglist: Fix DM header color lerp bug. #1336

merged 1 commit into from
Feb 7, 2025

Conversation

E-m-i-n-e-n-c-e
Copy link
Contributor

@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e commented Feb 7, 2025 •
edited by chrisbobbe
Loading

Fixed a bug in MessageListTheme.lerp() where dmRecipientHeaderBg was using streamMessageBgDefault instead of dmRecipientHeaderBg for interpolation.

@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e mentioned this pull request Feb 7, 2025
Open
@chrisbobbe
Copy link
Collaborator

(Edited the description to remove "Part of #1305", because this is an independent bugfix that's not part of fixing that PR's issue #681. The connection to #1305 is just that that's when you found the bug. 🙂)

@chrisbobbe
Copy link
Collaborator

LGTM, thanks! Marking for Greg's review.

@chrisbobbe chrisbobbe requested a review from gnprice February 7, 2025 20:18
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Feb 7, 2025
@gnprice
Copy link
Member

gnprice commented Feb 7, 2025

Thanks for the fix! Looks good — merging.

@E-m-i-n-e-n-c-e @gnprice
msglist: Fix DM header color lerp bug.
0e6cacb 
Fixed a bug in MessageListTheme.lerp() where dmRecipientHeaderBg was using
streamMessageBgDefault instead of dmRecipientHeaderBg for interpolation.
@gnprice gnprice merged commit 0e6cacb into zulip:main Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@E-m-i-n-e-n-c-e @chrisbobbe @gnprice