notif: Preserve target account context on back navigation after opening a notification #1373
Conversation
lakshya1goel
changed the title
lakshya1goel
changed the title
…ng a notification Fixes: zulip#1210
lakshya1goel
force-pushed
the
issue1210
branch
from
509ba69 to
790c6df
Compare
| || (topRoute as AccountRoute).accountId != route.accountId) { | ||
| HomePage.navigate(context, accountId: route.accountId); | ||
| navigator = await ZulipApp.navigator; | ||
| } |
There was a problem hiding this comment.
The popUntil above unconditionally clears the navigator stack until there is only one route left. I believe that this is equivalent to HomePage.navigate, which also pops all routes beforehand.
Either way, we should not pop all routes unconditionally, because it doesn't feel like great user experience when the existing routes already belong to the same account.
#F1210 suggests that we
switch to a new nav stack for the notification's account (if different) before pushing the message-list route.
I think what we need here is just a way to keep track of the currently active account, or a way to inspect the navigator stack without actually popping the routes.
There was a problem hiding this comment.
See discussion here: #mobile > Beta: after open via notification, back opens old server @ 💬. Feel free to ask questions if you have any!
Fixes: #1210
Description
When opening a notification from a different account B while in account A and pressing back, the app should stay in account B's context rather than returning to account A. This PR implements this behavior by:
Video Demonstration
WhatsApp.Video.2025-02-22.at.10.34.48.PM.mp4